Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADVAPP-98]: Resolve display of footer on mobile viewport size for custom pages. #379

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[ADVAPP-98]: Resolve display of footer on mobile viewport size for custom pages. #379

merged 1 commit into from
Dec 20, 2023

Conversation

dgoetzit
Copy link
Contributor

Ticket(s) or GitHub Issue

https://canyongbs.atlassian.net/browse/ADVAPP-98

Technical Description

This PR resolves an issue with the footer overlap on custom pages.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Screenshots (if appropriate)

Screenshot 2023-12-20 at 9 27 22 AM

Any deployment steps required?

  • No

Before contributing and submitting this PR, make sure you have:

  • Read the contributing guidelines.
  • Title the PR with the ticket/issue number and a short description of the changes made. Or if no ticket/issue exists, title the PR with a short description of the changes made
  • Linked a relevant ticket or issue or describe the issue/feature which this PR resolves/implements.
  • Resolved all conflicts, if any.
  • Rebased your branch PR on top of the latest upstream develop branch.

@dgoetzit dgoetzit self-assigned this Dec 20, 2023
@dgoetzit dgoetzit requested a review from a team December 20, 2023 14:27
@Orrison Orrison merged commit f49ba92 into develop Dec 20, 2023
5 checks passed
@Orrison Orrison deleted the fix/advapp-98-footer-display branch December 20, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orrison Orrison Orrison approved these changes

Assignees

@dgoetzit dgoetzit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgoetzit @Orrison