[ADVAPP-1033]: Refactor engagements for processing efficiency and delivery reliability #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orrison
force-pushed
the
chore/ADVAPP-1033
branch
from
7b4661b to
c2b18bb
Compare
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
…t model Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
…ences Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
…ationship Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Orrison
force-pushed
the
chore/ADVAPP-1033
branch
from
9fc1c74 to
e48938e
Compare
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
…nManager Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
…nt modules Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
…lity Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
… type Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
…atch tests Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
|
joelicatajr
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Refactor the way we store and dispatch Engagements. Removes the middleman EngagementDeliverable Model to simplify the relationship between an Engagement and an OutboundDeliverable.
Updates the notification process to reduce the bounce back and forth between the Notification and the Channel, now relying more heavily on the Channel and simply using the Notification for customization per type.
Any deployment steps required?
No
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Migrations:
app-modules/engagement/database/migrations/2024_12_23_231446_data_clear_out_outbound_deliverables_for_engagement_deliverables.phpapp-modules/engagement/database/migrations/2024_12_23_232117_data_truncate_engagements_table.phpBefore contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.