Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-1068]: Adjust the opacity of the checkboxes on the role view page when using light mode #1182

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

amit-canyon
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

Adjust the opacity of the checkboxes on the role view page when using light mode

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@amit-canyon amit-canyon added the Change Type | Content or Styling Update Changes which don't affect functionality label Dec 13, 2024
@amit-canyon amit-canyon requested a review from a team as a code owner December 13, 2024 11:44
Copy link
Collaborator

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct but @danharrin may work with this to fix it in Filament as well so leaving it up to you @danharrin for approval on this ticket.

Copy link
Contributor

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just made a Filament release that should solve the issue, can you please update Filament, build NPM, test that it works, and then remove this new line if it does?

Please let me know if it doesn't solve

@Orrison Orrison enabled auto-merge December 18, 2024 14:46
@Orrison Orrison added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 87fe0dc Dec 18, 2024
7 checks passed
@Orrison Orrison deleted the ADVAPP-1068 branch December 18, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Type | Content or Styling Update Changes which don't affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants