Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVAPP-1061]: Users who do not have a profile image set via SSO present a broken image as their avatar. #1180

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

Orrison
Copy link
Collaborator

@Orrison Orrison commented Dec 11, 2024

Ticket(s) or GitHub Issue

Technical Description

  • Fixes an issue with license addon data migration
  • Fixes a bug with the Azure Socialite login avatar retrieval
  • Data fixes removing all User Avatars that saved as JSON due to the previous bug
    • I am aware that I am breaking our rule to not use Model classes like Media. But I would like to propose an exception since this will be short lived and is the fastest way to ensure the media Model is deleted and the media itself is purged from storage.

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

Data Migration: database/migrations/2024_12_11_221606_data_remove_all_media_user_avatars_that_saved_as_json.php


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
@Orrison Orrison added the Change Type | Bug Fix Something isn't working label Dec 11, 2024
@Orrison Orrison self-assigned this Dec 11, 2024
@Orrison Orrison requested a review from a team as a code owner December 11, 2024 22:21
Orrison and others added 2 commits December 11, 2024 22:22
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
@Orrison Orrison enabled auto-merge December 11, 2024 22:48
@Orrison Orrison added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit b780acd Dec 11, 2024
7 checks passed
@Orrison Orrison deleted the bugfix/ADVAPP-1061 branch December 11, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Type | Bug Fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants