Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgraded to Larastan 3.0 and PHPStan 2.0 #191

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

odinns
Copy link

@odinns odinns commented Nov 27, 2024

Upgrades dependencies and fixes code and baselines.

@canvural
Copy link
Owner

canvural commented Dec 1, 2024

Hi,

Thank you for this.

And as this is a breaking change. Could you please target the 3.0.x branch?

@odinns
Copy link
Author

odinns commented Dec 2, 2024

Hi,

Thank you for this.

And as this is a breaking change. Could you please target the 3.0.x branch?

Sure I can do that, but the 3.0.x branch is a lot behind in commits from the v2 branch?

@odinns odinns changed the base branch from 2.1.x to 3.0.x December 2, 2024 09:17
@odinns
Copy link
Author

odinns commented Dec 2, 2024

Anyway I have done that now

@canvural
Copy link
Owner

canvural commented Dec 2, 2024

This is really weird 🤔

Is it possible for you to first checkout 3.0.x branch and then apply your changes? That way we'd also get rid of the merge conflicts.

@owenvoke
Copy link
Contributor

owenvoke commented Dec 2, 2024

Yeah, seems like it just needs to be applied onto the 3.0.x branch, can use this patch: commit.patch (there were some conflicts, so cleaned them up in the patch).

@odinns
Copy link
Author

odinns commented Dec 2, 2024

Should be good now 👍

@canvural
Copy link
Owner

canvural commented Dec 2, 2024

One last thing: we need to adjust the Github Actions to only run the latest versions. We can copy the versions from composer.json

@owenvoke
Copy link
Contributor

owenvoke commented Dec 2, 2024

Should be able to use this patch: commit.patch

Upgrades dependencies and fixes code and baselines.
@odinns
Copy link
Author

odinns commented Dec 2, 2024

Applied the patch and pushed 👍

@canvural canvural merged commit 64c82eb into canvural:3.0.x Dec 2, 2024
9 checks passed
@canvural
Copy link
Owner

canvural commented Dec 2, 2024

Alright, this looks good. Thank you so much @odinns and @owenvoke

@canvural
Copy link
Owner

canvural commented Dec 2, 2024

Released: https://github.com/canvural/larastan-strict-rules/releases/tag/3.0.0

Please let me know if you encounter any issues when you try it.

@odinns odinns deleted the 3.x branch December 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants