-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgraded to Larastan 3.0 and PHPStan 2.0 #191
Conversation
Hi, Thank you for this. And as this is a breaking change. Could you please target the 3.0.x branch? |
Sure I can do that, but the 3.0.x branch is a lot behind in commits from the v2 branch? |
Anyway I have done that now |
This is really weird 🤔 Is it possible for you to first checkout 3.0.x branch and then apply your changes? That way we'd also get rid of the merge conflicts. |
Yeah, seems like it just needs to be applied onto the 3.0.x branch, can use this patch: commit.patch (there were some conflicts, so cleaned them up in the patch). |
Should be good now 👍 |
One last thing: we need to adjust the Github Actions to only run the latest versions. We can copy the versions from |
Should be able to use this patch: commit.patch |
Upgrades dependencies and fixes code and baselines.
Applied the patch and pushed 👍 |
Released: https://github.com/canvural/larastan-strict-rules/releases/tag/3.0.0 Please let me know if you encounter any issues when you try it. |
Upgrades dependencies and fixes code and baselines.