Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create strongly typed PlanCommand class #6
Create strongly typed PlanCommand class #6
Changes from 1 commit
38004db
a0ce3c7
95ba2d2
c82ee5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phrasing suggestion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's steer right into this question: how do we keep this in sync with the platform? Suppose for example that we decided to add a new field, called
timeframe
, to the definition of the plan command on the platform, a duration of time within which the plan should be accomplished. How do we protect our customers from being the ones to discover the issues that might be entailed from getting out of sync?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: integration test? Is there something in
home-app
exposed via HTTP that returns the command schema? Would it serve our purpose to require that an SDK command class field of a given type exists if and only if it is present in the schema returned in thehome-app
integration test?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there is an endpoint exactly like that in home-app, i'll dig it up and make an integration test. we could also have a test that runs on a cron and checks daily or something. great idea to call this out