chore: fix integration tests #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaugunderson
approved these changes
Jan 27, 2025
…ration test instance is fixed
jamagalhaes
force-pushed
the
chore/fix-integration-tests
branch
from
940545d to
700dc8d
Compare
nmpsilva
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue with the
canvas_sdk/effects/banner_alert/tests.py::test_protocol_that_adds_banner_alerttest.However, the
canvas_sdk/commands/tests/protocol/tests.py::test_protocol_that_inserts_every_commandintegration test is still failing due to a regression introduced in version 1.146.0 of home-app. This regression broke theupdateGoalinterpreter, preventing that command type from being originated correctly.UPDATE: I'll ignore updateGoal command for now to unlock the release.