Build out http helper class #36
Conversation
| return _decorator(fn) if fn else _decorator | ||
|
|
||
| @measure_time | ||
| def get(self, url: str, headers: dict = {}) -> requests.Response: |
There was a problem hiding this comment.
A nice usability enhancement for all of these would be to allow passing in an optional dictionary of query parameters that we could encode for them, rather than making the user do it each time. This would map to the params argument in requests.
canvas_sdk/utils/http.py
Outdated
| return self.session.get(url, headers=headers) | ||
|
|
||
| @measure_time | ||
| def post(self, url: str, json: dict | None = None, headers: dict = {}) -> requests.Response: |
There was a problem hiding this comment.
Do we need to allow post, put, and patch to send non-JSON request bodies?
There was a problem hiding this comment.
i think we want to keep it simple for now, and if there is a need to add in more other uses like those (files, etc), we'll add them. it'll be simple enough since we're just copying the same api as the requests library and passing in.
There was a problem hiding this comment.
OK. The specific non-JSON use case I was thinking about was for request bodies that are application/x-www-form-urlencoded -- like requesting an OAuth token.
There was a problem hiding this comment.
that's a good one! i'll add it
https://canvasmedical.atlassian.net/browse/KOALA-1335
An abstraction on the requests library with the following methods:
getpostputpatchcreates a requests session and then passes calls through session methods. also a statsd wrapper to measure the timing of each call.
still todo: