Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional allowed imports #350

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: add additional allowed imports #350

merged 1 commit into from
Jan 22, 2025

Conversation

beaugunderson
Copy link
Member

@beaugunderson beaugunderson commented Jan 22, 2025

based on Denis' request here:

#332 (comment)

@beaugunderson beaugunderson requested a review from a team as a code owner January 22, 2025 21:26
@beaugunderson beaugunderson changed the title add additional allowed imports Add additional allowed imports Jan 22, 2025
@beaugunderson
Copy link
Member Author

@djantzen any concerns with adding these?

@beaugunderson beaugunderson changed the title Add additional allowed imports feat: add additional allowed imports Jan 22, 2025
@djantzen
Copy link
Contributor

@djantzen any concerns with adding these?

Not from a security perspective, although I'm far from expert in those libraries. At some point we may need to care about memory usage when importing libraries into plugins.

@beaugunderson
Copy link
Member Author

@djantzen any concerns with adding these?

Not from a security perspective, although I'm far from expert in those libraries. At some point we may need to care about memory usage when importing libraries into plugins.

agreed... only pydantic is a third-party library, the others are stdlib

and pydantic is already imported in many places in the SDK, which then gets included in the plugin runner, so this specific addition will not have memory impact, but I agree that yes, we should always do the work to understand memory impact of any imported modules regardless of who is writing the code

@beaugunderson beaugunderson merged commit 518c62c into main Jan 22, 2025
5 of 8 checks passed
@beaugunderson beaugunderson deleted the bg-add-imports branch January 22, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants