Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix python warnings #335

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

jamagalhaes
Copy link
Collaborator

This PR fixes the following deprecation warnings:

  1. plugin_runner/tests/test_application.py
PytestCollectionWarning: cannot collect test class 'TestApplication' because it has a __init__ constructor (from: plugin_runner/tests/test_application.py)
    class TestApplication(Application):
  1. plugin_runner/tests/test_plugin_installer.py::test_plugin_installation_from_tarball
DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13; Path objects as a context manager is a no-op
    with download_plugin(attributes["package"]) as plugin_file_path:
  1. plugin_runner/tests/test_application.py::test_compute_event_not_targeted
DeprecatedWarning: target is deprecated as of 0.11.0 and will be removed in 1.0.0. Use 'event.target.id' directly instead
    return [self.on_open()] if self.target == self.identifier else []

@jamagalhaes jamagalhaes requested a review from a team as a code owner January 16, 2025 17:00
@jamagalhaes jamagalhaes changed the title chore: fix deprecation warnings chore: fix python warnings Jan 16, 2025
@jamagalhaes jamagalhaes merged commit 22f83ff into main Jan 16, 2025
6 checks passed
@jamagalhaes jamagalhaes deleted the chore/fix-deprecation-warnings branch January 16, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants