fix: send sighup after installing when synchronizer boots, remove load com… #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand when ReloadPlugins is received since this occurs on plugin_runner start
beaugunderson
approved these changes
Jan 14, 2025
|
One of my changes in the initial PR was for the synchronizer to respond to its own restart command.
… On Jan 14, 2025, at 2:31 PM, Beau Gunderson ***@***.***> wrote:
@beaugunderson commented on this pull request.
In plugin_runner/plugin_runner.py <#324 (comment)>:
> @@ -193,7 +193,6 @@ async def ReloadPlugins(
) -> AsyncGenerator[ReloadPluginsResponse, None]:
"""This is invoked when we need to reload plugins."""
try:
- load_plugins()
can we actually remove this? IIRC we don't respond to our own restart message
—
Reply to this email directly, view it on GitHub <#324 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALB6UAQVGJDJPDPERDNWTD2KWF47AVCNFSM6AAAAABVFU5S62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJRGE3DIOBWG4>.
You are receiving this because you authored the thread.
--
Disclaimer: This e-mail and any attachments may contain confidential
information. If you are not the intended recipient, any disclosure,
copying, distribution or use of any information contained herein is
strictly prohibited. If you have received this transmission in error,
please immediately notify the Security Officer
***@***.***>, and destroy the original transmission
and any attachments without reading or saving.
|
|
good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix to address the problem reported by Patina in which plugins fail to run reliably after a home-app deploy.
The failure mode is a race condition in which plugins may be loaded into memory before the synchronizer has finished installing them on the file system. This solution causes the synchronizer to signal the runner to restart after installation, at which time the runner will load the plugins.
This solution results in some wasted work because the runner starts after the deploy and is shortly thereafter restarted. A better solution will embed the installation work into the plugin runner so that plugins can be loaded into memory after installation without requiring a restart. That work will be in a different changeset.