fix: remove boto3 #314
Merged
fix: remove boto3 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djantzen
commented
Jan 12, 2025
djantzen
force-pushed
the
fix/remove-boto
branch
2 times, most recently
from
2d506a9 to
dd19500
Compare
aduane
reviewed
Jan 15, 2025
aduane
approved these changes
Jan 15, 2025
djantzen
force-pushed
the
fix/remove-boto
branch
from
4e034ae to
cb90d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boto3 adds at minimum 35mb to the plugin_synchronizer, and all we're doing is downloading files from S3. This change borrows code from https://charemza.name/blog/posts/aws/python/you-might-not-need-boto-3/ and removes boto3.