Change auth from api-key to client credentials #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbiannaccone
commented
Apr 12, 2024
canvas_cli/apps/auth/utils.py
Outdated
| return expiration_date is not None and datetime.fromisoformat(expiration_date) > datetime.now() | ||
|
|
||
|
|
||
| def get_or_request_api_token(host: str, client_id: str | None, client_secret: str | None) -> str: |
There was a problem hiding this comment.
@beaugunderson this is the function you will call to get an oauth token for the deploy command
jrwils
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still todo:
i'm able to successfully test
canvas plugin listandcanvas plugin updateagainst live environments, but i can't testcanvas plugin installsince we've ripped out all the code needed for the old way of installing.