Adds command-specific event types. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduane
reviewed
Apr 11, 2024
jrwils
changed the title
|
Discussed in OneSDK Friday meeting: comment out the event types for commands that are not refactored yet so they do not show as available. cc: @aduane |
aduane
reviewed
Apr 16, 2024
|
|
||
| // Specific Command events | ||
|
|
||
| ADJUST_DIAGNOSIS_COMMAND__PRE_COMMAND_ORIGINATE = 1000; |
There was a problem hiding this comment.
Can we change these to remove the second "COMMAND"? Seems redundant.
Example:
Suggested change
| ADJUST_DIAGNOSIS_COMMAND__PRE_COMMAND_ORIGINATE = 1000; | |
| ADJUST_DIAGNOSIS_COMMAND__PRE_ORIGINATE = 1000; |
There was a problem hiding this comment.
@aduane I like it better if we remove the first COMMAND and keep the second one. The reason for this is that they match the naming of the canvas-core command events, which are named PreCommandOriginate, PostCommandOriginate, etc. How about ADJUST_DIAGNOSIS__PRE_COMMAND_ORIGINATE?
jrwils
force-pushed
the
feature/jw-koala-1276
branch
from
7cc332f to
2bf70f1
Compare
aduane
approved these changes
Apr 17, 2024
jrwils
force-pushed
the
feature/jw-koala-1276
branch
from
5d8928f to
aa81b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://canvasmedical.atlassian.net/browse/KOALA-1276