-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: a new implementation of the plugin installer that runs in the plugin #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f0cc39
to
6b592cd
Compare
6b592cd
to
39a6eae
Compare
a57c49d
to
d778b2e
Compare
hmm why did the chore commit with the version get created? that should be done by the github action being run manually after the PR is merged |
d778b2e
to
876a70f
Compare
I did a rebase since there were conflicts in poetry.lock. For some reason the chore commit from main was used here even though I updated the commit message.
… On Jan 2, 2025, at 12:33 PM, Beau Gunderson ***@***.***> wrote:
hmm why did the chore commit with the version get created? that should be done by the github action being run manually after the PR is merged
—
Reply to this email directly, view it on GitHub <#283 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALB6UFCEK256ZZCTAZJH6L2IWPDJAVCNFSM6AAAAABUNAGEAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRYGM2DIMRZGY>.
You are receiving this because you authored the thread.
--
Disclaimer: This e-mail and any attachments may contain confidential
information. If you are not the intended recipient, any disclosure,
copying, distribution or use of any information contained herein is
strictly prohibited. If you have received this transmission in error,
please immediately notify the Security Officer
***@***.***>, and destroy the original transmission
and any attachments without reading or saving.
|
djantzen
commented
Jan 2, 2025
876a70f
to
422fda9
Compare
csande
reviewed
Jan 3, 2025
@csande @beaugunderson I'm still having trouble with the pre commit hooks. Two problems at least:
|
a1cd1f3
to
d592ef6
Compare
aduane
reviewed
Jan 6, 2025
jamagalhaes
reviewed
Jan 7, 2025
…o longer will do so
…ry can be used and will be cleaned up after
20c00bc
to
5e87cc4
Compare
jamagalhaes
reviewed
Jan 9, 2025
aduane
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…runner instead of the home-app