Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: a new implementation of the plugin installer that runs in the plugin #283

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

djantzen
Copy link
Contributor

…runner instead of the home-app

@djantzen djantzen force-pushed the feature/koala-2300-new-plugin-installer branch 2 times, most recently from 8f0cc39 to 6b592cd Compare January 1, 2025 03:15
@djantzen djantzen changed the title A new implementation of the plugin installer that runs in the plugin … refactor: A new implementation of the plugin installer that runs in the plugin … Jan 1, 2025
@djantzen djantzen force-pushed the feature/koala-2300-new-plugin-installer branch from 6b592cd to 39a6eae Compare January 1, 2025 03:51
@beaugunderson beaugunderson changed the title refactor: A new implementation of the plugin installer that runs in the plugin … refactor: A new implementation of the plugin installer that runs in the plugin Jan 2, 2025
@beaugunderson beaugunderson changed the title refactor: A new implementation of the plugin installer that runs in the plugin refactor: a new implementation of the plugin installer that runs in the plugin Jan 2, 2025
@djantzen djantzen force-pushed the feature/koala-2300-new-plugin-installer branch 2 times, most recently from a57c49d to d778b2e Compare January 2, 2025 20:31
@beaugunderson
Copy link
Member

hmm why did the chore commit with the version get created? that should be done by the github action being run manually after the PR is merged

@djantzen djantzen force-pushed the feature/koala-2300-new-plugin-installer branch from d778b2e to 876a70f Compare January 2, 2025 20:34
@djantzen
Copy link
Contributor Author

djantzen commented Jan 2, 2025 via email

@djantzen djantzen force-pushed the feature/koala-2300-new-plugin-installer branch from 876a70f to 422fda9 Compare January 2, 2025 22:36
@djantzen djantzen marked this pull request as ready for review January 3, 2025 00:22
@djantzen djantzen requested a review from a team as a code owner January 3, 2025 00:22
plugin_runner/tests/test_plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/tests/test_plugin_installer.py Outdated Show resolved Hide resolved
settings.py Outdated Show resolved Hide resolved
@djantzen
Copy link
Contributor Author

djantzen commented Jan 4, 2025

@csande @beaugunderson I'm still having trouble with the pre commit hooks. Two problems at least:

  • running pre-commit run --all-files wants to upgrade a bunch of stuff in poetry.lock, even though I've already run poetry lock --no-update
  • There are a bunch of type system complaints out of mypy that I have no clue how to resolve.
    I might need to pair with someone on Monday to figure out how to close this out.

@djantzen djantzen force-pushed the feature/koala-2300-new-plugin-installer branch 3 times, most recently from a1cd1f3 to d592ef6 Compare January 5, 2025 21:14
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
plugin_runner/plugin_installer.py Outdated Show resolved Hide resolved
@djantzen djantzen force-pushed the feature/koala-2300-new-plugin-installer branch from 20c00bc to 5e87cc4 Compare January 8, 2025 20:37
@djantzen djantzen requested a review from aduane January 9, 2025 22:18
@djantzen djantzen merged commit 219f54e into main Jan 9, 2025
5 checks passed
@djantzen djantzen deleted the feature/koala-2300-new-plugin-installer branch January 9, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants