Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: targeting python 3.12 in CI #281

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Conversation

jamagalhaes
Copy link
Collaborator

@jamagalhaes jamagalhaes commented Dec 21, 2024

@beaugunderson did a small test in CI with py3.11

poetry run python ./test_build_dist.py

from semantic_release.cli.commands.version import build_distributions

build_distributions("poetry build")

and it worked.

I believe this was probably related with the cache. I've improved the cache keys for venv and poetry

@jamagalhaes jamagalhaes force-pushed the chore/fix-build-release branch 8 times, most recently from 49b99b1 to a142da4 Compare December 21, 2024 18:03
@jamagalhaes jamagalhaes force-pushed the chore/fix-build-release branch from a142da4 to 2c55922 Compare December 21, 2024 18:29
@jamagalhaes jamagalhaes changed the title wip: test build_command semantic release chore: improve cache keys for venv and poetry Dec 21, 2024
@jamagalhaes jamagalhaes marked this pull request as ready for review December 21, 2024 18:32
@jamagalhaes jamagalhaes requested a review from a team as a code owner December 21, 2024 18:32
@jamagalhaes jamagalhaes force-pushed the chore/fix-build-release branch from 043c888 to 2c55922 Compare December 21, 2024 18:48
@beaugunderson
Copy link
Member

should we stick with 3.11 or move forward to 3.12 regardless? GitHub is now enforcing 3.12 in their runners, and we've already had one compatibility issue that @andhines ran into trying to do pip install canvas on his local machine (which had 3.12 installed)

@jamagalhaes
Copy link
Collaborator Author

@beaugunderson done

@jamagalhaes jamagalhaes changed the title chore: improve cache keys for venv and poetry chore: targeting python 3.12 in CI Dec 26, 2024
@jamagalhaes jamagalhaes force-pushed the chore/fix-build-release branch from 28dac12 to 7724b69 Compare December 27, 2024 11:19
@jamagalhaes jamagalhaes merged commit c2ec60c into main Dec 27, 2024
5 checks passed
@jamagalhaes jamagalhaes deleted the chore/fix-build-release branch December 27, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants