-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: consolidate linters and formatter into Ruff for improved performance and simplicity #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e731af7
to
074c6ef
Compare
074c6ef
to
e2fb205
Compare
love it, this was on my list for home-app too--saw a complaint recently that it didn't do isort equivalent but it looks like it does based on your PR? |
beaugunderson
approved these changes
Nov 29, 2024
There are a few differences, you can check them here: https://docs.astral.sh/ruff/faq/#how-does-ruffs-import-sorting-compare-to-isort |
nmpsilva
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KOALA-2299
This PR replaces the existing linters and formatter with Ruff, a fast Python linter and code formatter. Ruff serves as a drop-in replacement for tools like Flake8 (including various plugins), isort, pydocstyle, pyupgrade, black, etc.
Key Changes:
black
,isort
,pydocstyle
—with Ruff, streamlining the development workflow.flake8-bugbear
(focus on code quality issues and best practices).flake8-comprehensions
(improves comprehension readability and efficiency).pydocstyle
(docstring conventions).pycodestyle
errors.Pyflakes
(static analysis for Python code).isort
(import sorting).flake8-simplify
(simplifies overly complex patterns).pyupgrade
(modernizes Python syntax).pycodestyle
warnings.Benefits:
IDE Integration:
Ruff supports integration with various editors and IDEs to enhance the development experience. For setup instructions, refer to the Editor Integration guide.