Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mixins for CommittableQuerySet and PatientAssetQuerySet #211

Merged
merged 4 commits into from
Jan 28, 2025
Merged

feat: add mixins for CommittableQuerySet and PatientAssetQuerySet #211

merged 4 commits into from
Jan 28, 2025

Conversation

jamagalhaes
Copy link
Collaborator

@jamagalhaes jamagalhaes commented Nov 26, 2024 •
edited by nmpsilva
Loading

@jamagalhaes jamagalhaes requested a review from a team as a code owner November 26, 2024 18:52
@jamagalhaes jamagalhaes marked this pull request as draft November 26, 2024 18:53
csande
csande reviewed Nov 26, 2024
View reviewed changes
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
jrwils
jrwils reviewed Nov 27, 2024
View reviewed changes
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
canvas_sdk/v1/data/condition.py Show resolved Hide resolved
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
@jamagalhaes jamagalhaes force-pushed the feat/generic-querysets branch 2 times, most recently from e470871 to fb2e6ce Compare December 5, 2024 21:45
@jamagalhaes
Copy link
Collaborator Author

@jrwils @csande I had some time today to get back to this work. Please take a look whenever it’s convenient for you. The only part I’m not particularly fan of is the casts required when using from_queryset to generate dynamic managers. Mypy doesn’t seem to handle them well, as it can’t infer the methods available in the queryset. If you have a better solution shout it.

@jamagalhaes jamagalhaes requested review from jrwils and csande December 5, 2024 21:53
@jamagalhaes jamagalhaes marked this pull request as ready for review December 5, 2024 21:54
csande
csande requested changes Dec 16, 2024
View reviewed changes
canvas_sdk/v1/data/base.py Show resolved Hide resolved
@jamagalhaes jamagalhaes force-pushed the feat/generic-querysets branch from fb2e6ce to dac0f3f Compare December 17, 2024 14:57
@jamagalhaes jamagalhaes requested a review from csande December 17, 2024 14:57
@jamagalhaes jamagalhaes force-pushed the feat/generic-querysets branch from dac0f3f to 7d00b5b Compare January 2, 2025 12:17
@jamagalhaes jamagalhaes force-pushed the feat/generic-querysets branch from 7d00b5b to e1cd657 Compare January 27, 2025 09:18
@nmpsilva nmpsilva mentioned this pull request Jan 27, 2025
Closed
@nmpsilva
Copy link
Contributor

FFR this PR should fix #292

@jamagalhaes jamagalhaes force-pushed the feat/generic-querysets branch from e1cd657 to 6555fc2 Compare January 28, 2025 10:44
@jamagalhaes jamagalhaes merged commit 4d8f609 into main Jan 28, 2025
5 checks passed
@jamagalhaes jamagalhaes deleted the feat/generic-querysets branch January 28, 2025 15:01
@aduane aduane mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csande csande csande approved these changes

@aduane aduane Awaiting requested review from aduane

@jrwils jrwils Awaiting requested review from jrwils

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamagalhaes @nmpsilva @jrwils @csande