Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add patient_filter to base effect's payload #192

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: add patient_filter to base effect's payload #192

merged 2 commits into from
Nov 19, 2024

Conversation

mbiannaccone
Copy link
Collaborator

@mbiannaccone mbiannaccone commented Nov 15, 2024 •
edited
Loading

this PR adds patient_filter as a property on the BaseEffect class, and allows to users to pass in either a patient_filter or patient_id to apply the effect to. https://canvasmedical.atlassian.net/browse/KOALA-2198

@mbiannaccone mbiannaccone marked this pull request as ready for review November 19, 2024 03:26
@mbiannaccone mbiannaccone requested a review from a team as a code owner November 19, 2024 03:26
aduane
aduane approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@aduane aduane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to document how to use this.

@mbiannaccone mbiannaccone merged commit 1757447 into main Nov 19, 2024
4 checks passed
@mbiannaccone mbiannaccone deleted the michela/koala-2198-patient-querysets branch November 19, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduane aduane aduane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbiannaccone @aduane