Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plugins functionality for protocol conversions #183

Merged
merged 15 commits into from
Nov 26, 2024
Merged

feat: plugins functionality for protocol conversions #183

merged 15 commits into from
Nov 26, 2024

Conversation

jrwils
Copy link
Contributor

@jrwils jrwils commented Nov 6, 2024 •
edited by aduane
Loading

@jrwils jrwils requested a review from a team as a code owner November 6, 2024 22:51
@jrwils jrwils requested a review from csande November 13, 2024 22:59
@jrwils jrwils force-pushed the csande/plugin-refactoring branch 2 times, most recently from 9105a57 to db2c249 Compare November 18, 2024 18:53
csande
csande reviewed Nov 18, 2024
View reviewed changes
canvas_sdk/protocols/clinical_quality_measure.py Outdated Show resolved Hide resolved
canvas_sdk/v1/data/note.py Outdated Show resolved Hide resolved
@jrwils jrwils force-pushed the csande/plugin-refactoring branch from 9483ead to a409b68 Compare November 19, 2024 22:30
@jrwils
Copy link
Contributor Author

jrwils commented Nov 19, 2024

@csande I made the changes to move the choice classes outside of the model classes and made the change to self.now for the timeframe. I also made the queryset/mixin changes we talked about and some mypy/typing additions/fixes. Please review at your convenience, thanks!

@csande csande self-requested a review November 20, 2024 19:32
csande
csande reviewed Nov 20, 2024
View reviewed changes
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
csande
csande reviewed Nov 20, 2024
View reviewed changes
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
canvas_sdk/v1/data/base.py Show resolved Hide resolved
jrwils and others added 13 commits November 25, 2024 11:26
@jrwils
feat: adds functionality for the hcc annual wellness visit protocol t…
500bc81 
…o be a plugin (#177)
@csande @jrwils
Added custom value sets for dysrhythmia CQM; some minor model updates…
5f4f018 
… to Condition and Medication
@csande @jrwils
Added a method on ClinicalQualityMeasure to obtain the patient ID fro…
8aa8750 
…m an event target
@csande @jrwils
Refactor set_patient_id into a getter that will only fetch the patien…
3ae3aed 
…t ID once
@csande @jrwils
Added django.db.models as an allowed module
0ea79d6
@jrwils
Adds .choices to model choices.
97f86ef
@jrwils @csande
@jamagalhaes @mbiannaccone @kristenoneill
feat: additions for diabetes mellitus protocol to plugin conversion (#…
71fbb75 
…193)

Signed-off-by: Kristen ONeill <91080969+kristenoneill@users.noreply.github.com>
Co-authored-by: Christopher Sande <christopher.sande@canvasmedical.com>
Co-authored-by: José Magalhães <jose.magalhaes@canvasmedical.com>
Co-authored-by: Michela Iannaccone <mbiannaccone@gmail.com>
Co-authored-by: Kristen ONeill <91080969+kristenoneill@users.noreply.github.com>
@jrwils
Adds now property to __init__ method.
e06267d
@jrwils
Moves choice classes outside of models.
a614735
@jrwils
Changes inherited queryset classes to mixins and adds mypy/typing pro…
7af7578 
…tocols.
@jrwils
Adds NotImplementedError to protocol class abstract methods.
2058df4
@jrwils
Changes base class in ValueSetTimeframeLookupQuerySet
fed9963
@jrwils
Fixes conflicts.
bf4e7b6
@jrwils jrwils force-pushed the csande/plugin-refactoring branch from 23e0547 to bf4e7b6 Compare November 25, 2024 19:38
@jrwils jrwils requested a review from aduane November 25, 2024 19:39
csande
csande requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@csande csande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small requested change.

Additionally, I will also point out that many if not all of the changes to files under v1/data will necessitate documentation updates as well. We all need to get into the habit of pairing documentation PRs with changes to these files, or little discrepancies are going to start creeping in.

canvas_sdk/v1/data/base.py Outdated Show resolved Hide resolved
@jrwils jrwils merged commit 69e95c8 into main Nov 26, 2024
4 checks passed
@jrwils jrwils deleted the csande/plugin-refactoring branch November 26, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduane aduane aduane approved these changes

@csande csande csande approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrwils @aduane @csande