feat(plugins): add support for importing other modules within a plugin #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamagalhaes
force-pushed
the
feat/koala-2189-plugin-mutiple-modules
branch
2 times, most recently
from
6e5e358 to
abcc0eb
Compare
|
@aduane I'm open to suggestions/improvements |
jamagalhaes
force-pushed
the
feat/koala-2189-plugin-mutiple-modules
branch
from
abcc0eb to
bb62d58
Compare
jamagalhaes
force-pushed
the
feat/koala-2189-plugin-mutiple-modules
branch
from
bb62d58 to
bfa133b
Compare
beaugunderson
approved these changes
Nov 12, 2024
aduane
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KOALA-2189
This PR adds support for importing other modules within a plugin package.
This PR also replaces the use of
find_specfromimportlib.utilwith a safer approach becausefind_specwill implicitly import the parent module when the given name refers to a submodule.In particular, this behavior presents a security risk: if a bad actor manages to inject malicious code into the
__init__.pyfile of the package, that code will execute as soon as the package is imported. Sincefind_specwill import the package to resolve submodules, any malicious code in__init__.pywill run even before the sandbox has a chance to apply its restrictions. cc @beaugunderson