feat: add protocol classname to effects and include in plugin_runner event handler #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduane
reviewed
Oct 23, 2024
jamagalhaes
force-pushed
the
michela/koala-1859-cqm-install-part2
branch
from
e3e027c to
d856c2f
Compare
mbiannaccone
force-pushed
the
michela/koala-1859-cqm-install-part2
branch
from
d856c2f to
87296fa
Compare
mbiannaccone
commented
Oct 28, 2024
aduane
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds
classnameas a field on effect and also populates it for all effects so that homeapp can properly process CQM's (and use/update the correct ProtocolCurrents, which rely on this classname!) . it also addssource_attributesas a key-value store on the Meta class to be passed to home-app. this satisfied a new onc requirement