Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull out meta properties of CQM protocols without importing file #140

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mbiannaccone
Copy link
Collaborator

Reagan reported that installing plugins doesn't work when the protocol file imports certain libraries. this is because we were previously using importlib to fully import those files to pull out the meta properties before install. This PR changes the mechanism for pulling out that info (using ast) so that we don't need to import!

slack thread with context: https://canvas-medical.slack.com/archives/C055B74UKJP/p1729204957000159?thread_ts=1729196011.314639&cid=C055B74UKJP

@mbiannaccone mbiannaccone requested a review from a team as a code owner October 18, 2024 17:40
@mbiannaccone mbiannaccone merged commit 1402f8e into main Oct 18, 2024
4 checks passed
@mbiannaccone mbiannaccone deleted the michela/protocol-meta-properties branch October 18, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants