-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: local development improvements #102
Conversation
canvas_cli/apps/emit/event_fixtures/ALLERGY_INTOLERANCE_CREATED.ndjson
Outdated
Show resolved
Hide resolved
Idea for consideration: Rather than making developers start the plugin runner and then emit to it, what if you combine those into a single subcommand called "test_plugin"? This command would start the plugin runner in a subprocess, emit the event, and then stop the plugin runner. I could see the iteration cycle where you have to start, emit, stop, edit, and repeat being mildly annoying (and maybe requiring multiple terminal windows), whereas if you combined start, emit, and stop into a single subcommand, your iteration cycle would just be test, change, and repeat. |
9653cd0
to
bf26792
Compare
I would like to improve the constant I also would like to keep in mind iteration workflows that depend on multiple events firing in a sequence. |
…f local development
80a0aa4
to
4e3f59a
Compare
This PR makes several changes with the goal of improving the plugin development workflow. (Development of plugins, not development of the SDK or the plugin runner)
Changes:
PLUGIN_RUNNER_SIGNING_KEY
being set emits a warning with instructions on how to eliminate the message instead of raising an exception. (7ef6fb7)emit
CLI command can't connect to a running plugin runner process, an error message is shown instead of an exception.Still working on:
1. Making data accessible without access to a Canvas EMR database. (Substitute a sqlite database seeded with data and provide a way to add/modify the data)Out of scope, will work on this in a separate PR.