Adds NotImplementedError to protocol class abstract methods.

canvas-medical · Nov 20, 2024 · 00f40e0 · 00f40e0
1 parent 829cecf
commit 00f40e0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/canvas_sdk/v1/data/base.py b/canvas_sdk/v1/data/base.py
@@ -49,13 +49,13 @@ class ValueSetLookupQuerySetProtocol(QuerySetProtocol):
     @abstractmethod
     def codings(value_set: Type["ValueSet"]) -> tuple[tuple[str, set[str]]]:
         """A protocol method for defining codings."""
-        ...
+        raise NotImplementedError
 
     @staticmethod
     @abstractmethod
     def q_object(system: str, codes: Container[str]) -> Q:
         """A protocol method for defining Q objects for value set lookups."""
-        ...
+        raise NotImplementedError
 
 
 class ValueSetLookupQuerySetMixin(ValueSetLookupQuerySetProtocol):
@@ -132,8 +132,7 @@ class TimeframeLookupQuerySetProtocol(QuerySetProtocol):
     @abstractmethod
     def timeframe_filter_field(self) -> str:
         """A protocol method for timeframe_filter_field."""
-
-    ...
+        raise NotImplementedError
 
 
 class TimeframeLookupQuerySetMixin(TimeframeLookupQuerySetProtocol):