Issue: Failures are showing up as updates in the notification

[markyuk]

All files are up to date.
One person has an MS Projector MPP file open on my PC.
I see in the log 11 lines consecutively that the file is in use.
Every few seconds I receive a tray notification telling me there's been 11 updates.
This happened all day so I've now told the person to close the file!
I'm no longer receiving tray notifications of 11 updates.

It looks like the updates are linked to both failures as well as successful sync updates and I expect the failures to not be part of the notifications.

Here's an example of the failure in the log ---

2015-11-12 10:01:32.1141 [Debug] SyncTrayzor.SyncThing.EventWatcher.SyncThingEventWatcher: Received 1 events 2015-11-12 10:01:32.1051 [Debug] SyncTrayzor.SyncThing.EventWatcher.SyncThingEventWatcher: <ItemStarted ID=646 Time=12/11/2015 10:01:32 Item=Client Work\Lovely Client\Scoping\Project Plan\Lovely project plan.mpp Folder=Company Type=File Action=Update> 2015-11-12 10:01:32.1141 [Debug] SyncTrayzor.SyncThing.TransferHistory.SyncThingTransferHistory: Item started. Folder: Company, Item: Client Work\Lovely Client\Scoping\Project Plan\Lovely project plan.mpp, Type: File, Action: Update 2015-11-12 10:01:32.1311 [Debug] SyncTrayzor.SyncThing.TransferHistory.SyncThingTransferHistory: Created file transfer: <FileTransfer Folder=Company Path=Client Work\Lovely Client\Scoping\Project Plan\Lovely project plan.mpp Status=Started ItemType=File ActionType=Update Started=12/11/2015 10:01:32 Finished=> 2015-11-12 10:01:32.1311 [Debug] SyncTrayzor.SyncThing.EventWatcher.SyncThingEventWatcher: <ItemFinished ID=647 Time=12/11/2015 10:01:32 Item=Client Work\Lovely Client\Scoping\Project Plan\Lovely project plan.mpp Folder=Company Error=remove \\?\e:\Company\Client Work\Lovely Client\Scoping\Project Plan\Lovely project plan.mpp: The process cannot access the file because it is being used by another process.> 2015-11-12 10:01:32.1311 [Debug] SyncTrayzor.SyncThing.TransferHistory.SyncThingTransferHistory: Item finished. Folder: Company, Item: Client Work\Lovely Client\Scoping\Project Plan\Lovely project plan.mpp, Type: File, Action: Update 2015-11-12 10:01:32.1451 [Debug] SyncTrayzor.SyncThing.TransferHistory.SyncThingTransferHistory: File Transfer set to complete: <FileTransfer Folder=Company Path=Client Work\Lovely Client\Scoping\Project Plan\Lovely project plan.mpp Status=Completed ItemType=File ActionType=Update Started=12/11/2015 10:01:32 Finished=12/11/2015 10:01:32>

[canton7]

Do you want to be told that there were failures at all?

[canton7]

It would seem prudent to warn the user that some file transfers failed. However, if we're doing this every few minutes (and we will, most likely), then that gets very annoying very fast. Not sure what the best middle ground is. Warn only once per file? Then you've got a case where we've got 1 file that consistently fails, and if another file succeeds SyncTrayzor will say "1 file succeeded", implying no files failed, when in fact that persistent failure is still there.

[markyuk]

I like your last comment - want to know there's a failure but not every few minutes on the same file. I can choose to open the app and see the total fails anyway if I've been notified once.

[canton7]

Righty. This is half in (see 14159b9), but I'll need to put in tracking for seen failed files.

[canton7]

Righty, that's in but not yet tested. Please give it a whirl and let me know if you find something broken 😄 https://ci.appveyor.com/project/canton7/synctrayzor/build/1.0.29.161/artifacts

[markyuk]

Great, thank you! Installed and will report back if needed :-)