-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic customisation for menubar colors #343
base: master
Are you sure you want to change the base?
Conversation
Thanks @V1RE! The only problem is if we merge this, we need to support these options even in an eventually, more configurable world. Perhaps thats fine though. |
Do you want to go through and wire up other color options too (text, background, highlight)? |
Sure, what env vars should I use? |
MCFLY_PROMPT_COLOR, MCFLY_HIGHLIGHT_COLOR, MCFLY_SELECTION_COLOR might be all of them? |
@cantino What to do with the lightmode setting? this would kind of make that obsolete, right? |
Can we integrate this with the new configuration system #407? |
#156 looks promising, but hasn't seen much action in the last 2 years. So I
made a quick and simple way to customize the foreground and background colors of the menubar using env vars.
Haven't used rust too much, so lmk if I can improve on anything