Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove features that we don't want in v35 #3378

Merged
merged 23 commits into from
Feb 13, 2025
Merged

Remove features that we don't want in v35 #3378

merged 23 commits into from
Feb 13, 2025

Conversation

orndorffgrant
Copy link
Collaborator

@orndorffgrant orndorffgrant commented Jan 9, 2025 •
edited by renanrodrigo
Loading

Why is this needed

Because main should have only what is going to be released.

  • (un)check this to re-run the checklist action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited by renanrodrigo
Loading

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

None.

Confirm

  • I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs
  • If this PR is related to a Jira item, include an SC-1234 reference in the PR title
  • If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
  • If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

  • I have updated or added any unit tests accordingly
  • No unit test changes are necessary for this change

Integration Tests

  • I have updated or added any integration tests accordingly
  • No integration test changes are necessary for this change

Documentation

  • Changes here need to be documented and I have referenced the docs PR in the description
  • No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

  • Yes, and I have requested those reviews via GitHub
  • No

@renanrodrigo
Copy link
Member

@orndorffgrant after the CVE work lands I'll take this one

@orndorffgrant
Copy link
Collaborator Author

@renanrodrigo reminder that this PR still needs to remove the status APIs as well.

@renanrodrigo renanrodrigo marked this pull request as ready for review February 10, 2025 20:08
@renanrodrigo
Copy link
Member

I reverted the status API PRs, and will double check if there is something else to remove. If something is at the top of mind, please tell me here @orndorffgrant @lucasmoura @dheyay

@orndorffgrant
Copy link
Collaborator Author

This looks like it is removing all the right things. I think we should be able to get this PR to green CI (maybe minus the fix tests? what is the state of those?)

@renanrodrigo
Copy link
Member

renanrodrigo commented Feb 11, 2025 •
edited
Loading

you are right - this should be good minus fix
fix is a nightmare
status is, as I would better describe in portuguese:
api quebra nada acontece feijoada

orndorffgrant and others added 22 commits February 11, 2025 23:57
@orndorffgrant @renanrodrigo
config: remove cli_color and cli_suggestions
bdd4f67
@renanrodrigo
Revert "api: u.pro.status.notices.v1"
154f109 
This reverts commit 35693dd.
@renanrodrigo
Revert "Add integration test"
bdedc79 
This reverts commit b6048b6.
@renanrodrigo
Revert "Add new step to output and token_info schema"
eba29ef 
This reverts commit fd8fcff.
@renanrodrigo
Revert "Update simulate_status with new error messages"
b56d61e 
This reverts commit 41c2f9f.
@renanrodrigo
Revert "Update handling errors due to contract expiration"
c307974 
This reverts commit 94c044f.
@renanrodrigo
Revert "Add new error message and exception"
771324b 
This reverts commit f663a8d.
@renanrodrigo
Revert "api: u.pro.token_info.v1"
9d96aa3 
This reverts commit b7038e0.
@renanrodrigo
Revert "api: u.pro.services.list.v1"
ea99ad2 
This reverts commit 75129ed.
@renanrodrigo
cli: remove support for suggestions
d11c739 
Signed-off-by: Renan Rodrigo <renanrodrigo@canonical.com>
@renanrodrigo
Revert "tests: fix u.pro.services.dependencies.v1 order"
11cbe6d 
This reverts commit 68b1906.
@renanrodrigo
Revert "postinst: migrate CIS to USG on Focal and Jammy"
e1ac8f2 
This reverts commit 133c20a.
@renanrodrigo
Revert "entitlements: enable USG instead of CIS on Focal"
af8376f 
This reverts commit 7a187f1.
@renanrodrigo
Revert "chore: turn ENTITLEMENT_CLASSES into a function"
71786b9 
This reverts commit b4caa31.
@renanrodrigo
Revert "entitlements: separate CIS and USG by series"
2303c01 
This reverts commit 6d4ce25.
@renanrodrigo
Revert "entitlements: add 'USG' as an entitlement"
be31247 
This reverts commit 2610fc2.
@renanrodrigo
Revert "entitlements: make each entitlement have a single name"
ee1f0d3 
This reverts commit caeeb0d.
@renanrodrigo
Revert "entitlements: ignore any presentedAs information from the bac…
a226ef5 
…kend"

This reverts commit db20560.
@renanrodrigo
Revert "Rename endpoint to access"
3326660 
This reverts commit 2d957a2.
@renanrodrigo
Revert "tests update"
de92dc6 
This reverts commit ebe0810.
@renanrodrigo
Revert "api: u.pro.config.v1"
b9f8914 
This reverts commit ccc0264.
@renanrodrigo
Revert "api: u.pro.subscription.v1"
3cca919 
This reverts commit 2312a49.
@renanrodrigo
fix: return Enum values in config_status
ae65e9c 
This fix had been applied in the config API, now reverted. Bringing it
back to make sure config objects are serializable.

Signed-off-by: Renan Rodrigo <renanrodrigo@canonical.com>
@renanrodrigo
Copy link
Member

@orndorffgrant I believe this PR has the sanest possible CI now - fix tests are horrible, help text is wrong but @lucasmoura has #3387 for it, and the cursed apt news selector test in Xenial needs to be fixed but it was there before

@renanrodrigo renanrodrigo merged commit ceffbc3 into main Feb 13, 2025
18 of 24 checks passed
@renanrodrigo renanrodrigo deleted the remove-undesired branch February 13, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmoura lucasmoura lucasmoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orndorffgrant @renanrodrigo @lucasmoura