noble: add noble to tests (SC-1647) #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira: SC-1647 GitHub Issues: Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references) Documentation: The changes in this PR do not require documentation changes. 👍 this comment to confirm that this is correct. |
orndorffgrant
changed the title
orndorffgrant
force-pushed
the
noble-pro
branch
from
689622c to
d79d1ce
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
2 times, most recently
from
a650c78 to
64d2188
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
4 times, most recently
from
60a6647 to
7215319
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
7 times, most recently
from
73a35c9 to
b1ec5fa
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
from
b1ec5fa to
22cec43
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
from
22cec43 to
ac243df
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
2 times, most recently
from
58b9483 to
1b8e5b0
Compare
orndorffgrant
changed the title
orndorffgrant
force-pushed
the
noble-pro
branch
3 times, most recently
from
a9cf3e5 to
315cf87
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
7 times, most recently
from
a40eac5 to
3ff325a
Compare
orndorffgrant
force-pushed
the
noble-pro
branch
2 times, most recently
from
6ef38a5 to
c087243
Compare
without these directories, apt prints warnings on noble Fixes: #3060
orndorffgrant
force-pushed
the
noble-pro
branch
from
c087243 to
a98867a
Compare
dheyay
approved these changes
Apr 19, 2024
| else | ||
| SKIP_PROPOSED="--skip-proposed" | ||
| fi | ||
| sg sbuild -c "mk-sbuild $SKIP_PROPOSED ${{ matrix.release }}" |
There was a problem hiding this comment.
Just curious, what does the skip-proposed flag do here?
| @@ -33,3 +33,6 @@ Feature: Full Auto-Attach Endpoint | |||
| | jammy | aws.pro | | |||
| | jammy | azure.pro | | |||
| | jammy | gcp.pro | | |||
| | noble | aws.pro | | |||
| | noble | azure.pro | | |||
| | noble | gcp.pro | | |||
There was a problem hiding this comment.
Is there a reason we do not test this feature on mantic here?
There was a problem hiding this comment.
Saw mantic missing on a few other tests which test across all releases too
There was a problem hiding this comment.
mantc has no Pro images - Those are only for LTS
lucasmoura
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This PR adds noble to all the relevant tests
Test Steps
CI for noble should pass
Checklist
Does this PR require extra reviews?