Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postinst: remove unneeded check for deb-systemd-helper #1993

Merged

Conversation

orndorffgrant
Copy link
Collaborator

Proposed Commit Message

postinst: remove unneeded check for deb-systemd-helper

deb-systemd-helper is a part of init-system-helpers, which is
Essential: yes, so the check here was superfluous.

Test Steps

Install an old version of ua that has ua-messaging.timer. Upgrade to this version and make sure ua-messaging.timer is cleaned up correctly.

Or say "this doesn't really benefit us and we don't want to bother with the extra testing here so lets just leave it as it was" - that would make sense too :) - then we can just close this PR

Desired commit type

  • Squash and merge: Using the "Proposed Commit Message"
  • Create a merge commit and use "Proposed Commit Message"
  • Rebase and merge, no merge commit, rely only on existing commit messages

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • I have updated or added any documentation accordingly

deb-systemd-helper is a part of init-system-helpers, which is
Essential: yes, so the check here was superfluous.
@renanrodrigo renanrodrigo merged commit db5bf78 into canonical:main Mar 23, 2022
@orndorffgrant orndorffgrant deleted the essential-pkg-check-unneeded branch August 9, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants