Add Dockerfile to create an OCI image of agent #179
Conversation
1. testflinger-agent 2. testflinger-cli 3. device-connector and could change the set by environment variables while starting.
|
/canonical/self-hosted-runners/run-workflows 802441a |
|
Can you tell me more about what this is for? I'd be happy to see something like this as a mechanism for integration testing, but for actual use - it's a bad pattern to have the entire agent stack run inside a container. In fact, most of the device connectors will not work well like this currently. What I would recommend for actual use, is to have only the test phase run inside a container. This way you get a clean, reproducible environment every time, while still allowing the other phases to operate in a less restricted way. |
|
As discuss and the conclusion in Riga, OEM team will only use test command for now and ask me to put what OEM team has into this repository. |
There was a problem hiding this comment.
After a bit more discussion today, here are some changes we are recommending in order to merge this:
- Move this to agent/extra instead of agent/docker - this gives a better indication that this is "extra" and not needed for general use
- Document at the top of the README that this is for a specific use case and that most device connectors will not function properly this way, so it's not recommended for use in most cases.
|
May I move to |
|
@hanhsuan yes, that should work |
2. Notice user this is for a specific use case in README
|
/canonical/self-hosted-runners/run-workflows 9e10be3 |
Description
Add Dockerfile to create an OCI image includes
and could change the settings by environment variables while starting.
Resolved issues
Documentation
Tests