Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retention period #29

Merged
merged 19 commits into from
Sep 11, 2024
Merged

Retention period #29

merged 19 commits into from
Sep 11, 2024

Conversation

PietroPasotti
Copy link
Contributor

added configurable retention period for the compactor module. default 30 days

@PietroPasotti
Copy link
Contributor Author

blocked by canonical/cos-lib#66

@PietroPasotti
Copy link
Contributor Author

rebased on #31

Copy link

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as everything looks like it should work, but I had a few suggestions to consider

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
charmcraft.yaml Outdated Show resolved Hide resolved
tests/integration/test_ingressed_tls.py Outdated Show resolved Hide resolved
@PietroPasotti PietroPasotti merged commit 71e6d63 into main Sep 11, 2024
13 checks passed
@sed-i sed-i deleted the retention-period branch September 17, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants