-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: port the how-to/quickstart chapter from discourse #5176
docs: port the how-to/quickstart chapter from discourse #5176
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5176 +/- ##
==========================================
- Coverage 94.88% 89.70% -5.18%
==========================================
Files 658 341 -317
Lines 55189 22587 -32602
==========================================
- Hits 52364 20262 -32102
+ Misses 2825 2325 -500 ☔ View full report in Codecov by Sentry. |
ca8232f
to
a7145f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, many of my comments are opinions - feel free to ignore them if they are out of scope.
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as this is fine as is, but I left some improvement suggestions.
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Spread failure unrelated, it was a network problem when downloading a container. |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)For CRAFT-3578