Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: port the how-to/quickstart chapter from discourse #5176

Merged

Conversation

medubelko
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

For CRAFT-3578

@medubelko medubelko requested review from mr-cal and a team December 11, 2024 11:46
@medubelko medubelko marked this pull request as ready for review December 11, 2024 11:47
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (654871d) to head (50b1446).
Report is 658 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (50b1446). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (50b1446)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5176      +/-   ##
==========================================
- Coverage   94.88%   89.70%   -5.18%     
==========================================
  Files         658      341     -317     
  Lines       55189    22587   -32602     
==========================================
- Hits        52364    20262   -32102     
+ Misses       2825     2325     -500     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@medubelko medubelko force-pushed the craft-3578-consolidate-howto-quickstarts branch from ca8232f to a7145f7 Compare December 11, 2024 16:59
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, many of my comments are opinions - feel free to ignore them if they are out of scope.

docs/howto/select-a-build-provider.rst Outdated Show resolved Hide resolved
docs/howto/select-a-build-provider.rst Show resolved Hide resolved
docs/howto/select-a-build-provider.rst Outdated Show resolved Hide resolved
docs/howto/select-a-build-provider.rst Outdated Show resolved Hide resolved
docs/howto/set-up-snapcraft.rst Show resolved Hide resolved
docs/reference/anatomy-of-a-recipe.rst Outdated Show resolved Hide resolved
docs/reference/code/wethr-recipe.yaml Outdated Show resolved Hide resolved
docs/reference/channels.rst Show resolved Hide resolved
docs/reference/snap-build-process.rst Show resolved Hide resolved
docs/reference/snap-build-process.rst Show resolved Hide resolved
medubelko and others added 4 commits December 11, 2024 15:06
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Co-authored-by: Callahan <callahan.kovacs@canonical.com>
@medubelko medubelko requested a review from mr-cal December 12, 2024 02:18
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mr-cal mr-cal requested a review from lengau December 12, 2024 19:07
docs/reference/system-requirements.rst Outdated Show resolved Hide resolved
docs/howto/set-up-snapcraft.rst Outdated Show resolved Hide resolved
docs/howto/set-up-snapcraft.rst Outdated Show resolved Hide resolved
docs/howto/set-up-snapcraft.rst Show resolved Hide resolved
docs/howto/set-up-snapcraft.rst Show resolved Hide resolved
docs/howto/set-up-snapcraft.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this is fine as is, but I left some improvement suggestions.

@medubelko medubelko enabled auto-merge (squash) December 12, 2024 22:40
@medubelko medubelko disabled auto-merge December 12, 2024 22:41
@medubelko medubelko enabled auto-merge (squash) December 12, 2024 22:41
@medubelko medubelko disabled auto-merge December 13, 2024 00:29
@mr-cal mr-cal added the squash label Dec 13, 2024
@mr-cal
Copy link
Collaborator

mr-cal commented Dec 13, 2024

Spread failure unrelated, it was a network problem when downloading a container.

@mr-cal mr-cal merged commit 2df2881 into canonical:main Dec 13, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants