Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use craft-platforms for build plans #5111

Merged
merged 24 commits into from
Oct 18, 2024
Merged

feat: use craft-platforms for build plans #5111

merged 24 commits into from
Oct 18, 2024

Conversation

mattculler
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@mattculler mattculler self-assigned this Oct 11, 2024
@mattculler mattculler linked an issue Oct 11, 2024 that may be closed by this pull request
Use craft-platforms for build plans #5015
Closed
@mattculler mattculler force-pushed the work/CRAFT-3322-build-plan-from-craft-platforms branch 4 times, most recently from 92416e5 to f3882fd Compare October 17, 2024 14:49
@mattculler mattculler marked this pull request as ready for review October 17, 2024 19:52
@mattculler mattculler requested review from lengau and mr-cal October 17, 2024 19:53
lengau
lengau approved these changes Oct 18, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
snapcraft/models/project.py Outdated Show resolved Hide resolved
mr-cal
mr-cal approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattculler
build(deps): update craft-platforms version to latest
89985dc
@mattculler
feat(model): naive build planner logic replacement
65cde65
@mattculler
feat(models): convert c-plat buildinfo to c-prov buildinfo
da4ed5f
@mattculler
chore: autoformat
891017a
@mattculler
fix: types
244b6bd
@mattculler
fix: name qualification
ae935e1
@mattculler
chore: format
9feaba5
@mattculler
fix: account for platforms none; undo accidental makefile changes
e1e7e1a
@mattculler
fix: invert logic to try to make type checker happy
bb49656
@mattculler
fix: 1/2 type checker issues
4dd7921
@mattculler
fix: add extra checking to appease type checkers
a332df3
@mattculler
fix: use in-progress fixed c-plat
61de255
@mattculler
chore: local unit tests aren't working, add -v to see diffs
0d692d7
@mattculler
chore: need the full diff
f9e12b0
@mattculler
feat: bring back some of the original build planner logic
5903572
@mattculler
fix: re-use type/base validation logic
d10e0e6
@mattculler
fix: undo accidental commit of dependencies at local path
675fb4c
@mattculler mattculler force-pushed the work/CRAFT-3322-build-plan-from-craft-platforms branch from 6a62112 to a36792f Compare October 18, 2024 20:49
@mattculler mattculler enabled auto-merge (squash) October 18, 2024 20:49
@mattculler mattculler merged commit 7969ee8 into main Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@lengau lengau lengau approved these changes

Assignees

@mattculler mattculler

Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use craft-platforms for build plans
3 participants
@mattculler @lengau @mr-cal