Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/kde-neon-6: fix XDG_CONFIG_DIRS #5104

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

soumyaDghosh
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (654871d) to head (4f5c2e0).
Report is 650 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (654871d) and HEAD (4f5c2e0). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (654871d) HEAD (4f5c2e0)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5104      +/-   ##
==========================================
- Coverage   94.88%   89.70%   -5.18%     
==========================================
  Files         658      341     -317     
  Lines       55189    22587   -32602     
==========================================
- Hits        52364    20262   -32102     
+ Misses       2825     2325     -500     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarlettGatelyMoore
Copy link
Contributor

Thank you, except this PR needs to be done here: https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration

@soumyaDghosh
Copy link
Contributor Author

Thank you, except this PR needs to be done here: https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration

Let's merge it here until it's used from here, else we'll not be able to use the change.

@soumyaDghosh
Copy link
Contributor Author

@sergiusens @lengau I think we can merge this. The Code Coverage issue is not related to this I think.

@ScarlettGatelyMoore
Copy link
Contributor

@sergiusens @lengau I think we can merge this. The Code Coverage issue is not related to this I think.

@soumyaDghosh can you please also do a pr here for this https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration

@soumyaDghosh
Copy link
Contributor Author

@sergiusens @lengau I think we can merge this. The Code Coverage issue is not related to this I think.

@soumyaDghosh can you please also do a pr here for this https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration

Very sorry, I forgot about this. It's done!

https://invent.kde.org/neon/snap-packaging/snapcraft-desktop-integration/-/merge_requests/2

@soumyaDghosh
Copy link
Contributor Author

@sergiusens @lengau kindly merge this...

@castle-giant
Copy link

I'm running into this and it's very frustrating. Is there anything I can do to help getting this merged? @soumyaDghosh

@soumyaDghosh
Copy link
Contributor Author

I'm running into this and it's very frustrating. Is there anything I can do to help getting this merged? @soumyaDghosh

This MR should be merged. If you want a quick work around for existing snaps, then create a symlink of .config/kdeglobals in
snap/snap_name/current/.config/kdeglobals

@castle-giant
Copy link

Adding the symlink didn't help, thanks anyway though! I'll have to be patient.

@soumyaDghosh
Copy link
Contributor Author

Adding the symlink didn't help, thanks anyway though! I'll have to be patient.

Which snap is it? Also what's the exact path did you put the file?

@castle-giant
Copy link

This is for kasts. I ran '~/snap/kasts/current/.config$ ln --symbolic ~/.config/kdeglobals'

@soumyaDghosh
Copy link
Contributor Author

This is for kasts. I ran '~/snap/kasts/current/.config$ ln --symbolic ~/.config/kdeglobals'

So is there, in snap/kasts/current/.config, a file named kdeglobals showing up?

@castle-giant
Copy link

castle-giant commented Dec 7, 2024 via email

@soumyaDghosh
Copy link
Contributor Author

Yes!On Dec 6, 2024, at 22:14, সৌম্যদীপ ঘোষ @.> wrote: So is there, in snap/kasts/current/.config, a file named kdeglobals showing up? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.>

Working for me, Let's not hijack this thread and ping me in matrix.

image

@mr-cal mr-cal merged commit ded34ae into canonical:main Dec 10, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants