fix: allow parallel installations of signed snapcraft snaps #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/CRAFT-3259/snap-alias
branch
from
7bc6d30 to
2f5ec00
Compare
mr-cal
changed the title
mr-cal
changed the title
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/CRAFT-3259/snap-alias
branch
from
2f5ec00 to
f188bf5
Compare
mr-cal
force-pushed
the
work/CRAFT-3259/snap-alias
branch
from
f188bf5 to
f86542b
Compare
Rename legacy variables to match snapd's definition: snap_name->snap_instance_name (possibly aliased) snap_store_name->snap_name (unaliased) Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/CRAFT-3259/snap-alias
branch
from
f86542b to
091e9a3
Compare
|
requesting @lengau and @mattculler as they already reviewed #5087 |
lengau
approved these changes
Oct 4, 2024
mattculler
approved these changes
Oct 4, 2024
This was referenced Oct 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Fixes a bug where parallel installations of snapcraft would not work if the snapcraft snap was signed.
I recommend reviewing by commit as the refactor commit is noisy.
Fixes #4683
Fixes #4927
(CRAFT-3259)