Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add edit-registries command #5050

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Supports the first half of the edit-registries command where a user can retrieve and edit a registries set.

The second half will be implemented in #5018.

Builds on top of #5049, so ignore the first commit.

I broke this up into 2 commits to make reviewing easier.

Fixes #5020
(CRAFT-3333)

@mr-cal mr-cal requested review from cmatsuoka and lengau September 19, 2024 12:18
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only added a note about changing a help message that's not very helpful.

snapcraft/commands/registries.py Outdated Show resolved Hide resolved
@mr-cal mr-cal force-pushed the work/CRAFT-3333/edit-registries branch from a389c60 to efac998 Compare September 20, 2024 13:25
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3333/edit-registries branch from efac998 to 6a5ca6b Compare September 20, 2024 19:26
@mr-cal mr-cal added the rebase label Sep 20, 2024
@mr-cal mr-cal merged commit b813cee into main Sep 20, 2024
8 of 10 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3333/edit-registries branch September 20, 2024 20:57
@medubelko
Copy link
Contributor

@mr-cal We have list-validation-sets and edit-validation-sets in the docs, but list-registries is missing its counterpart edit-registries. Can we redress this without too much effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registries: collect and edit registries
4 participants