Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): add 8.4.0 release notes #5027

Merged
merged 2 commits into from
Sep 12, 2024
Merged

docs(changelog): add 8.4.0 release notes #5027

merged 2 commits into from
Sep 12, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 10, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Release notes for 8.4.0 and an update to craft-parts 2.1.0 to include the fix for canonical/craft-parts#804.

@mr-cal mr-cal added the rebase label Sep 10, 2024
craft-parts 2.1.0 adds a Poetry plugin. This plugin disabled until
the integration work in #5025 is completed.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@tigarmo
Copy link
Contributor

tigarmo commented Sep 10, 2024 via email

@mr-cal
Copy link
Collaborator Author

mr-cal commented Sep 10, 2024

I'm out of the office but does this include a craft application release for the "pack - - debug" fix?

Ack, thanks. Looks like those got missed in craft-application's release notes: https://canonical-craft-application.readthedocs-hosted.com/en/latest/reference/changelog.html

fix: canonical/craft-application#454

@tigarmo
Copy link
Contributor

tigarmo commented Sep 10, 2024

I'm out of the office but does this include a craft application release for the "pack - - debug" fix?

Ack, thanks. Looks like those got missed in craft-application's release notes: https://canonical-craft-application.readthedocs-hosted.com/en/latest/reference/changelog.html

fix: canonical/craft-application#454

No no: 4.1.2 does not have that fix (on purpose I believe)

@mr-cal
Copy link
Collaborator Author

mr-cal commented Sep 10, 2024

No no: 4.1.2 does not have that fix (on purpose I believe)

Dang, I'm running in circles. I looked at the log of main, not 4.1.2...

@mr-cal mr-cal requested review from tigarmo and removed request for a team September 10, 2024 16:09
docs/reference/changelog.rst Outdated Show resolved Hide resolved
docs/reference/changelog.rst Outdated Show resolved Hide resolved
docs/reference/changelog.rst Outdated Show resolved Hide resolved
docs/reference/changelog.rst Outdated Show resolved Hide resolved
docs/reference/changelog.rst Outdated Show resolved Hide resolved
@mr-cal mr-cal requested a review from medubelko September 11, 2024 12:05
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal enabled auto-merge (rebase) September 12, 2024 12:02
@mr-cal mr-cal merged commit b5a564b into hotfix/8.4 Sep 12, 2024
10 of 12 checks passed
@mr-cal mr-cal deleted the release/8.4.0 branch September 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants