Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setup Python env for tiobe ci #4899

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: setup Python env for tiobe ci #4899

merged 1 commit into from
Jul 9, 2024

Conversation

sergiusens
Copy link
Collaborator

Also shallow checkout like the other workflows

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@sergiusens sergiusens requested review from lengau and mr-cal July 8, 2024 19:56
with:
fetch-depth: 0

- name: Setup Python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for consistency or is it failing with the system python3.10?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the shallow checkout to potentially fix https://github.com/canonical/snapcraft/actions/runs/9844524213/job/27178103576 which is a version parsing issue (my view is that if configured the same it should work the same)

The python thing is to keep it consistent with the pull_request triggered flow, by keeping them in sync it is much easier to anticipate errors as it is not easy to test something that runs on main pushes only

Also shallow checkout like the other workflows
@sergiusens sergiusens merged commit 0668b6c into main Jul 9, 2024
8 of 10 checks passed
@sergiusens sergiusens deleted the tiobe branch July 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants