Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support "build-for: [all]" in core24 #4873

Merged
merged 6 commits into from
Jun 28, 2024
Merged

feat: support "build-for: [all]" in core24 #4873

merged 6 commits into from
Jun 28, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 24, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Supports build-for: [all] for core24 snaps.

Fixes #4854
CRAFT-3017

@mr-cal mr-cal requested review from cmatsuoka and lengau June 25, 2024 15:54
lengau
lengau reviewed Jun 27, 2024
View reviewed changes
snapcraft/models/project.py Outdated Show resolved Hide resolved
tests/spread/core24/remote-build/task.yaml Outdated Show resolved Hide resolved
tests/unit/models/test_projects.py Show resolved Hide resolved
@mr-cal mr-cal force-pushed the work/CRAFT-3017-build-for-all branch from 8c3c472 to e85f731 Compare June 27, 2024 21:17
lengau
lengau approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@cmatsuoka
Copy link
Contributor

Nice work, just keep in mind that the platform handling code is starting to get confusing and we may want to detangle that at some point.

@mr-cal
Copy link
Collaborator Author

mr-cal commented Jun 28, 2024

rebasing and force-pushing to:

  • squash changes from PR feedback
  • change craft-application to 3.0.0
  • add unit and spread tests for all in advanced grammar

@mr-cal mr-cal force-pushed the work/CRAFT-3017-build-for-all branch from 6f63a85 to dbcb7e9 Compare June 28, 2024 19:03
mr-cal added 6 commits June 28, 2024 17:27
@mr-cal
build(deps): bump craft-application to 3.0.0
0c1ae34 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
chore: use craft-application Platforms model
f057cfa 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
fix: raise ValueErrors in validators
7b6c1c3 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
feat: support "build-for: [all]" in core24
d6fc95e 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
tests: add remote-build spread tests
ff8eb2b 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal
docs: updates for platforms and architectures
08036d7 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-3017-build-for-all branch from dbcb7e9 to 08036d7 Compare June 28, 2024 22:27
@mr-cal mr-cal enabled auto-merge (rebase) June 28, 2024 22:32
@mr-cal mr-cal merged commit e034a5e into main Jun 28, 2024
9 of 10 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo left review comments

@lengau lengau lengau approved these changes

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees
No one assigned
Labels
rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept build-for: [all] and --build-for=all for architecture-independent snaps
4 participants
@mr-cal @cmatsuoka @tigarmo @lengau