Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local keys for package-repos in core24 #4758

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Apr 24, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

@tigarmo tigarmo marked this pull request as ready for review April 24, 2024 13:35
@tigarmo tigarmo requested review from mr-cal and lengau April 24, 2024 13:43
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending my question upstream

@tigarmo tigarmo force-pushed the CRAFT-2826-support-local-keys branch from d050028 to c5c9d59 Compare April 24, 2024 20:33
@mr-cal mr-cal force-pushed the CRAFT-2826-support-local-keys branch from c5c9d59 to a3834e7 Compare April 24, 2024 23:00
@mr-cal mr-cal enabled auto-merge (rebase) April 24, 2024 23:14
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (hotfix/8.2@7b01ab0). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff              @@
##             hotfix/8.2    #4758   +/-   ##
=============================================
  Coverage              ?   89.57%           
=============================================
  Files                 ?      331           
  Lines                 ?    22079           
  Branches              ?        0           
=============================================
  Hits                  ?    19778           
  Misses                ?     2301           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-cal mr-cal merged commit b8ff64b into hotfix/8.2 Apr 25, 2024
11 of 12 checks passed
@mr-cal mr-cal deleted the CRAFT-2826-support-local-keys branch April 25, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants