Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote)!: use craft-application remote build for core22 #4724

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

syu-w
Copy link
Contributor

@syu-w syu-w commented Apr 11, 2024

Deprecated and removed old remote build code. Use new remote-build for core22.

Core20 can also use the new remote build if set env SNAPCRAFT_REMOTE_BUILD_STRATEGY="disable-fallback"

--build-on no longer supported.

Fixes: #4710

Deprecated and removed old remote build code. Use new remote-build for
core22.

Core20 can also use the new remote build if set env
SNAPCRAFT_REMOTE_BUILD_STRATEGY="disable-fallback"
@syu-w syu-w force-pushed the CRAFT-2659-new-remote-build branch from cf51086 to 12d6b49 Compare April 11, 2024 01:45
@syu-w syu-w requested review from mr-cal and lengau April 11, 2024 16:00
@syu-w syu-w marked this pull request as ready for review April 11, 2024 16:00
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please do a pair of unit tests for the new function

snapcraft/application.py Outdated Show resolved Hide resolved
snapcraft/application.py Outdated Show resolved Hide resolved
snapcraft/commands/core22/remote.py Outdated Show resolved Hide resolved
snapcraft/application.py Show resolved Hide resolved
snapcraft/application.py Outdated Show resolved Hide resolved
snapcraft/application.py Outdated Show resolved Hide resolved
@lengau lengau requested a review from mr-cal April 12, 2024 20:19
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@syu-w
Copy link
Contributor Author

syu-w commented Apr 12, 2024

The git repo check is in canonical/craft-application#310

@syu-w syu-w merged commit 9905f28 into main Apr 12, 2024
13 of 16 checks passed
@syu-w syu-w deleted the CRAFT-2659-new-remote-build branch April 12, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove core22 remote-builder in favour of craft-application remote-builder
3 participants