-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New kde-neon extension for Qt6 / KF6 #4698
New kde-neon extension for Qt6 / KF6 #4698
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4698 +/- ##
==========================================
+ Coverage 89.54% 89.57% +0.03%
==========================================
Files 337 338 +1
Lines 22638 22711 +73
==========================================
+ Hits 20271 20344 +73
Misses 2367 2367 ☔ View full report in Codecov by Sentry. |
Fix the target for kf6 to point to its own dir kf6. Fix test accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Spread tests are failing due to https://forum.snapcraft.io/t/kde-global-auto-connect-request/39535
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
- One related question (ABI stability)
- One curiosity question
- Two minor change requests to satisfy lawyers
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Remove the qt6 platform plug as we bundle the qt6 in the kf6 runtime due to limited to one platform plug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Michał Sawicz <michal@sawicz.net>
seems like the connection is not happening in the test:
do we wait for this or manually connect for now? I am ok with either, but I am intending to cut a release tomorrow |
I am good with manually connect if it's not to late. |
I just had to add fix 2b439f9e75c1e05e1aa5219a455c8239c3e79f9a to our $HOME ref: https://forum.snapcraft.io/t/setting-home-in-snap-to-user-home-seems-to-cause-all-empty-user-dirs-to-become-broken-symlinks/39463/5 |
…ME dirs." This reverts commit 221e23c.
@ScarlettGatelyMoore manual connect is good if you can do it now |
… for $HOME dirs."" This reverts commit 44c5615.
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Tests pass locally.