Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Snapcraft plugins in craft-application codepath #4672

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Mar 15, 2024

Two commits: one registers the plugins in the craft-application codepath, and one adds the confinement and base variables to the lifecycle (so that plugins can use it).

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (a019fe7) to head (dda0f79).
Report is 39 commits behind head on feature/craft-application.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/craft-application    #4672      +/-   ##
=============================================================
+ Coverage                      89.14%   89.33%   +0.19%     
=============================================================
  Files                            331      336       +5     
  Lines                          22078    22345     +267     
=============================================================
+ Hits                           19682    19963     +281     
+ Misses                          2396     2382      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigarmo
Copy link
Contributor Author

tigarmo commented Mar 15, 2024

This doesn't fix any spread tests but introduces a new, correct failure for tests/spread/core24/snap-creation:package_cutoff:

2024-03-15T18:57:19.2265172Z :: Python interpreter not found in payload.
2024-03-15T18:57:19.2266481Z :: + symlink_target=
2024-03-15T18:57:19.2267539Z :: + '[' -z '' ']'
2024-03-15T18:57:19.2268556Z :: + echo 'No suitable Python interpreter found, giving up.'
2024-03-15T18:57:19.2269497Z :: No suitable Python interpreter found, giving up.
2024-03-15T18:57:19.2270310Z :: + exit 1

@tigarmo tigarmo marked this pull request as ready for review March 15, 2024 20:08
@tigarmo tigarmo requested review from cmatsuoka and sergiusens March 15, 2024 20:08
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test to make sure list-plugins is working as expected.

@tigarmo tigarmo requested a review from cmatsuoka March 18, 2024 17:07
tigarmo added 2 commits March 18, 2024 18:18
Not all plugins have been verified to work with core24 yet, but we can't verify
them if they're not registered.
@tigarmo tigarmo force-pushed the craft-app-plugins branch from 8fff45f to dda0f79 Compare March 18, 2024 21:18
@tigarmo
Copy link
Contributor Author

tigarmo commented Mar 18, 2024

@sergiusens please rebase merge

@sergiusens sergiusens merged commit 9a5dc60 into feature/craft-application Mar 18, 2024
10 of 12 checks passed
@sergiusens sergiusens deleted the craft-app-plugins branch March 18, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants