-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Snapcraft plugins in craft-application codepath #4672
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4672 +/- ##
=============================================================
+ Coverage 89.14% 89.33% +0.19%
=============================================================
Files 331 336 +5
Lines 22078 22345 +267
=============================================================
+ Hits 19682 19963 +281
+ Misses 2396 2382 -14 ☔ View full report in Codecov by Sentry. |
This doesn't fix any spread tests but introduces a new, correct failure for tests/spread/core24/snap-creation:package_cutoff:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test to make sure list-plugins
is working as expected.
Not all plugins have been verified to work with core24 yet, but we can't verify them if they're not registered.
8fff45f
to
dda0f79
Compare
@sergiusens please rebase merge |
Two commits: one registers the plugins in the craft-application codepath, and one adds the confinement and base variables to the lifecycle (so that plugins can use it).