fix(test): use prime dir in some tests #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4661 +/- ##
=============================================================
+ Coverage 89.14% 89.32% +0.17%
=============================================================
Files 331 335 +4
Lines 22078 22288 +210
=============================================================
+ Hits 19682 19909 +227
+ Misses 2396 2379 -17 ☔ View full report in Codecov by Sentry. |
sergiusens
changed the title
sergiusens
reviewed
Mar 13, 2024
syu-w
force-pushed
the
work/ignore-same-file
branch
from
569c4fa to
6ae98a5
Compare
tigarmo
reviewed
Mar 14, 2024
syu-w
force-pushed
the
work/ignore-same-file
branch
2 times, most recently
from
4fb0323 to
a92e2d2
Compare
syu-w
changed the title
syu-w
force-pushed
the
work/ignore-same-file
branch
from
a92e2d2 to
d95c5ee
Compare
sergiusens
reviewed
Mar 14, 2024
syu-w
force-pushed
the
work/ignore-same-file
branch
from
d95c5ee to
29e7bd4
Compare
sergiusens
approved these changes
Mar 14, 2024
sergiusens
force-pushed
the
work/ignore-same-file
branch
from
29e7bd4 to
c8e131e
Compare
tigarmo
approved these changes
Mar 14, 2024
sergiusens
pushed a commit
that referenced
this pull request
Mar 15, 2024
There are 2 bugs: First, the current fixture `snapcraft_yaml` may create 2 `snapcraft.yaml` in `/` and `/snap/` due to it used in different places and it is default to `/snap/snapcraft.yaml`. When both `snapcraft.yaml` exists, the `/snapcraft.yaml` is used without any error / warning. The second bug is when `/snap/snapcraft.yaml` exists, `/build-aux/snap` will be ignored even if it had hooks in it. This is probably expected behavior since these are two different versions of the structure. Needs #4661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add prime dir in some tests.