Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: replace mock methods removed in Py3.12 #4640

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Mar 6, 2024

Mock.called_with was never actually a real mock method in unittest.mock. It was returning a Mock object, which is truthy.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

`Mock.called_with` was never actually a real mock method in `unittest.mock`. It was returning a Mock object, which is truthy.
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (c44101e) to head (7d5564d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4640      +/-   ##
==========================================
- Coverage   89.16%   88.34%   -0.83%     
==========================================
  Files         343      327      -16     
  Lines       23883    21966    -1917     
==========================================
- Hits        21295    19405    -1890     
+ Misses       2588     2561      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lengau lengau marked this pull request as ready for review March 6, 2024 18:57
@sergiusens sergiusens merged commit d364154 into main Mar 6, 2024
9 of 11 checks passed
@sergiusens sergiusens deleted the work/aml/py3.12 branch March 6, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants