chore: spread cleanup #4634
Merged
chore: spread cleanup #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4634 +/- ##
=============================================================
+ Coverage 89.14% 89.16% +0.01%
=============================================================
Files 331 333 +2
Lines 22078 22166 +88
=============================================================
+ Hits 19682 19764 +82
- Misses 2396 2402 +6 ☔ View full report in Codecov by Sentry. |
tigarmo
reviewed
Mar 5, 2024
spread.yaml
Outdated
|
|
||
| tests/spread/core24/environment/: | ||
|
|
||
| tests/spread/core24-suites/environment/: | ||
| summary: core24 environment tests | ||
| systems: | ||
| - ubuntu-22.04* |
There was a problem hiding this comment.
A bunch of these tests run in destructive mode, are they supposed to run on jammy still?
There was a problem hiding this comment.
good catch! I thought I did that update
There was a problem hiding this comment.
ok, with the current setup:
2024-03-05T14:38:09.8946667Z - google:ubuntu-22.04-64:tests/spread/core24-suites/environment/test-variables:test_variables
2024-03-05T14:38:09.8949593Z - google:ubuntu-22.04-64:tests/spread/core24-suites/manifest/manifest-creation:envvars
2024-03-05T14:38:09.8953244Z - google:ubuntu-22.04-64:tests/spread/core24-suites/patchelf/classic-patchelf
2024-03-05T14:38:09.8970397Z - google:ubuntu-22.04-64:tests/spread/core24-suites/patchelf/strict-patchelf
With Ubuntu 24.04 -> 39541c6
- google:ubuntu-24.04-64:tests/spread/core24-suites/environment/paths:staged_common_library
- google:ubuntu-24.04-64:tests/spread/core24-suites/environment/test-variables:test_variables
- google:ubuntu-24.04-64:tests/spread/core24-suites/manifest/manifest-creation:envvars
- google:ubuntu-24.04-64:tests/spread/core24-suites/patchelf/classic-patchelf
- google:ubuntu-24.04-64:tests/spread/core24-suites/patchelf/strict-patchelf
- google:ubuntu-24.04-64:tests/spread/core24-suites/scriptlets/scriptlet-failures
The last one is probably my old version of spread, the patchelf ones I think I can fix up to the point where they properly fail again due to our lack of classic confinement support -> e8f688e
lengau
reviewed
Mar 5, 2024
Comment on lines
8
to
9
| rm -f ./*.snap ./*.assert ./linter_output.txt | ||
| rm -f ./*.snap |
There was a problem hiding this comment.
Suggested change
| rm -f ./*.snap ./*.assert ./linter_output.txt | |
| rm -f ./*.snap | |
| rm -f ./*.snap ./*.assert ./linter_output.txt |
There was a problem hiding this comment.
I will do this when I rebase the PR you took over
lengau
approved these changes
Mar 5, 2024
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- Rename the test that uses gnome to explicitly call it out - Rename generated snap names for easy reuse - Remove the lint file with assertions test as it is base independent Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
This will be supported in another form in the future (exposing all work directories from the provider in the project) Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Centrally set `SNAPCRAFT_BUILD_ENVIRONMENT: ""` at the suite level instead of in each individual task, this setting should eventually be the default. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Suite hierarchy the way it was has little benefit, and causes confusion when navigating. It also implies more duplication in spread.yaml. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
It is a task, not a suite Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Tests are running out of space now. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
craftctl is the only future. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Use a 24.04 system for the core24-suite
- Use --destructive-mode in the CLI - Remove dangling set-base logic - Remove unbound references to base These tests still fail, but now they fail due to the lack of the classic feature. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
spread-factore
branch
from
e8f688e to
ca4912f
Compare
syu-w
approved these changes
Mar 5, 2024
tigarmo
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)