Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spread): enable pkg-repo tests for core24 #4621

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

sergiusens
Copy link
Collaborator

This mainly removes the --use-lxd toggle, there is no reason for it as it is the default.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (6ff3e0b) to head (8eb3199).
Report is 22 commits behind head on feature/craft-application.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/craft-application    #4621      +/-   ##
=============================================================
+ Coverage                      88.83%   89.12%   +0.28%     
=============================================================
  Files                            327      331       +4     
  Lines                          22033    22065      +32     
=============================================================
+ Hits                           19573    19665      +92     
+ Misses                          2460     2400      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This mainly removes the --use-lxd toggle, there is no reason for it as
it is the default.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens requested review from mr-cal and tigarmo February 28, 2024 23:46
@sergiusens sergiusens merged commit 383a857 into feature/craft-application Feb 29, 2024
8 of 11 checks passed
@sergiusens sergiusens deleted the spread-core24-tests branch February 29, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants