feat!: deprecate enable-manifest and manifest-image-information #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syu-w
force-pushed
the
work/CRAFT-2476-deprecated-info-manifest
branch
from
fde93fd to
d894ba2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4618 +/- ##
=============================================================
+ Coverage 88.83% 89.14% +0.31%
=============================================================
Files 327 331 +4
Lines 22033 22080 +47
=============================================================
+ Hits 19573 19684 +111
+ Misses 2460 2396 -64 ☔ View full report in Codecov by Sentry. |
`--enable-manifest` and `--manifest-image-information` no longer supported in core24.
syu-w
force-pushed
the
work/CRAFT-2476-deprecated-info-manifest
branch
from
d894ba2 to
301a6fe
Compare
sergiusens
reviewed
Feb 28, 2024
sergiusens
reviewed
Feb 28, 2024
mr-cal
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Will you please update https://snapcraft.io/docs/build-options to match this? (and mention the env vars to use instead)
|
…ted-info-manifest
sergiusens
approved these changes
Mar 4, 2024
sergiusens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--enable-manifestand--manifest-image-informationno longer supported in core24.