feat(craft-application): support root packages for core24 #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to use "build-packages" and "build-snaps" at the root level of the snapcraft.yaml file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/craft-application #4617 +/- ##
=============================================================
+ Coverage 88.83% 89.12% +0.29%
=============================================================
Files 327 331 +4
Lines 22033 22078 +45
=============================================================
+ Hits 19573 19678 +105
+ Misses 2460 2400 -60 ☔ View full report in Codecov by Sentry. |
mr-cal
approved these changes
Feb 28, 2024
tests/unit/models/test_projects.py
Outdated
| class TestProjectTransform: | ||
| """Test Transform the Project.""" | ||
|
|
||
| def test_root_packages_transform(self, project_yaml_data): |
There was a problem hiding this comment.
May be useful to have a test to ensure projects without build-packages and build-snaps are unmodified (i.e. the if statement on line 181)
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to use "build-packages" and "build-snaps" at the root level of the snapcraft.yaml file.
Fixes: #4605